acw/simple_asn1
1
0
Fork 0
Code Issues 5 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Consider implementing std Error for ASN1DecodeErr and ASN1EncodeErr #1

New Issue
Closed
opened 2018-10-23 12:10:46 -07:00 by mehcode · 3 comments
mehcode commented 2018-10-23 12:10:46 -07:00 (Migrated from github.com)
Copy Link
No description provided.
acw commented 2018-10-26 12:06:55 -07:00 (Migrated from github.com)
Copy Link

I think I've gotten this in place in 823fc31f6f (and the commit just prior). I was going to take a few days to think about the other issue you filed, but I can push this to crates as a minor change if you're in a hurry?

I think I've gotten this in place in 823fc31f6f9ba0636207226901f46d50eb1fdd01 (and the commit just prior). I was going to take a few days to think about the other issue you filed, but I can push this to crates as a minor change if you're in a hurry?
mehcode commented 2018-10-26 12:33:57 -07:00 (Migrated from github.com)
Copy Link

Take your time. Thank you for the excellent crate. It surprises me that there are dozens of ASN.1 crates but most don't seem very complete (unlike this one). My code will work fine for now, these requests would just improve it (this one in removing the error wrapper I currently need and the other in improving the performance a good bit).

Take your time. Thank you for the excellent crate. It surprises me that there are dozens of ASN.1 crates but most don't seem very complete (unlike this one). My code will work fine for now, these requests would just improve it (this one in removing the error wrapper I currently need and the other in improving the performance a good bit).
acw commented 2018-10-26 13:27:55 -07:00 (Migrated from github.com)
Copy Link

Yeah, that was my experience, as well. Hence this crate. Plus I wanted to learn Rust. :)

Glad this works for you. As I said, I'll take a look at the other issue soon, and get back to you. For now, I'm going to close this one, though.

Yeah, that was my experience, as well. Hence this crate. Plus I wanted to learn Rust. :) Glad this works for you. As I said, I'll take a look at the other issue soon, and get back to you. For now, I'm going to close this one, though.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
acw
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: acw/simple_asn1#1
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?