acw/simple_asn1
1
0
Fork 0
Code Issues 5 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Why is OID not Eq? #23

New Issue
Closed
opened 2021-06-03 12:21:00 -07:00 by randombit · 1 comment
randombit commented 2021-06-03 12:21:00 -07:00 (Migrated from github.com)
Copy Link

OID impls PartialEq but not Eq even though (AFAICT) OID equality satisfies Eq - is this just an oversight? Would you accept a patch adding Eq?

OID impls `PartialEq` but not `Eq` even though (AFAICT) OID equality satisfies `Eq` - is this just an oversight? Would you accept a patch adding `Eq`?
acw commented 2021-06-03 13:12:51 -07:00 (Migrated from github.com)
Copy Link

I believe it's an oversight. If you can add it, and everything compiles and passes the test suite, I'm cool with a patch.

I believe it's an oversight. If you can add it, and everything compiles and passes the test suite, I'm cool with a patch.
👍 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
acw
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: acw/simple_asn1#23
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?