acw/simple_asn1
1
0
Fork 0
Code Issues 5 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Use vec! in oid! macro #30

Merged
tsoutsman merged 1 commits from master into master 2022-01-03 14:57:56 -08:00
Conversation 1 Commits 1 Files Changed 1 +1 -6
tsoutsman commented 2022-01-03 03:16:39 -08:00 (Migrated from github.com)
Copy Link

Hi,
This pull request changes the oid! macro to use the vec! macro rather than manually creating a vector and then pushing elements onto it one-by-one. The vec! macro creates a vector that is already of the correct size avoiding unnecessary reallocations.

Hi, This pull request changes the `oid!` macro to use the `vec!` macro rather than manually creating a vector and then pushing elements onto it one-by-one. The `vec!` macro creates a vector that is already of the correct size avoiding unnecessary reallocations.
acw commented 2022-01-03 14:57:51 -08:00 (Migrated from github.com)
Copy Link

Looks great, thanks!

Looks great, thanks!
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
acw
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: acw/simple_asn1#30
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?