acw/simple_asn1
1
0
Fork 0
Code Issues 5 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Set time/quickcheck feature only in dev #31

Merged
connec merged 1 commits from quickcheck-dev into master 2022-03-13 20:19:31 -07:00
Conversation 2 Commits 1 Files Changed 1 +2 -1
connec commented 2022-03-13 13:17:14 -07:00 (Migrated from github.com)
Copy Link

I noticed when working on a crate that quickcheck was showing up in the Cargo.lock, which I thought was odd since I wasn't using it and it seems like something that ought to be under a feature. Turns out it was coming from time, which does put it behind a feature, but simple_asn1 always turns it on!

This PR simply duplicates the time dependency in dev-dependencies, and removes the quickcheck feature from the non-dev entry.

Since nothing is re-exported from time this ought to be a non-breaking change. I'm not familiar enough with how feature resolution works to say for certain that it couldn't break builds – perhaps if a user of both simple_asn1 and time was depending on Time::arbitrary without explicitly enabling it themselves...?

I noticed when working on a crate that `quickcheck` was showing up in the `Cargo.lock`, which I thought was odd since I wasn't using it and it seems like something that ought to be under a feature. Turns out it was coming from `time`, which does put it behind a feature, but `simple_asn1` always turns it on! This PR simply duplicates the `time` dependency in `dev-dependencies`, and removes the `quickcheck` feature from the non-dev entry. Since nothing is re-exported from `time` this ought to be a non-breaking change. I'm not familiar enough with how feature resolution works to say for certain that it couldn't break builds – perhaps if a user of both `simple_asn1` and `time` was depending on `Time::arbitrary` without explicitly enabling it themselves...?
acw commented 2022-03-13 20:19:18 -07:00 (Migrated from github.com)
Copy Link

Oh, interesting. Thanks for the patch! I'll merge it in. Let me think about whether we should bump the patch or minor version on this. You're right: it feels like this shouldn't affect anyone, but there are some weird edge cases in Cargoland.

Is this messing with something you're doing right now, or just a funny thing you noticed? Just trying to gauge how quick you're wanting a release to Crates.

Oh, interesting. Thanks for the patch! I'll merge it in. Let me think about whether we should bump the patch or minor version on this. You're right: it feels like this shouldn't affect anyone, but there are some weird edge cases in Cargoland. Is this messing with something you're doing right now, or just a funny thing you noticed? Just trying to gauge how quick you're wanting a release to Crates.
connec commented 2022-03-14 03:51:14 -07:00 (Migrated from github.com)
Copy Link

Thanks for the fast response! Yeah this is just a weird thing I noticed, nothing urgent for me.

Thanks for the fast response! Yeah this is just a weird thing I noticed, nothing urgent for me.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
acw
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: acw/simple_asn1#31
Delete Branch "quickcheck-dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?