acw/simple_asn1
1
0
Fork 0
Code Issues 5 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

BigUint(0) bug fixed (encode_base127) #10

Merged
twjang merged 1 commits from master into master 2019-09-11 22:05:17 -07:00
Conversation 1 Commits 1 Files Changed 1 +13
twjang commented 2019-09-11 18:23:42 -07:00 (Migrated from github.com)
Copy Link

Hello! First of all, I am really grateful for your sharing this useful library.
I accidentally found this bug while encoding oid(1.3.132.0.10) (which is secp256k1) into DER format. I added a small fix for encode_base127 function so that it returns a vector with one 0 byte when BigUint(0) was given.

Hello! First of all, I am really grateful for your sharing this useful library. I accidentally found this bug while encoding oid(1.3.132.0.10) (which is secp256k1) into DER format. I added a small fix for encode_base127 function so that it returns a vector with one 0 byte when BigUint(0) was given.
acw commented 2019-09-11 22:05:20 -07:00 (Migrated from github.com)
Copy Link

Perfect. Thanks!

Perfect. Thanks!
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
acw
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: acw/simple_asn1#10
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?