Fix all clippy warnings in the current code under Rust 1.56. #29

2021-11-14T07:21:52-08:00

nmathewson commented

2021-11-14 07:21:52 -08:00

(Migrated from github.com)

None of these are serious issues, but they seemed worth fixing.

I've verified that the code is still accepted by Rust versions back to 1.51, which appears to be the oldest version that simple_asn1 currently supports.

None of these are serious issues, but they seemed worth fixing. I've verified that the code is still accepted by Rust versions back to 1.51, which appears to be the oldest version that simple_asn1 currently supports.

Flakebi (Migrated from github.com) reviewed 2021-11-14 11:58:08 -08:00

src/lib.rs

Flakebi (Migrated from github.com) commented

2021-11-14 11:58:08 -08:00

I feel a bit sorry for marking such a little thing, but there is a space missing after the = ;)

Nice find of the time parsing panic btw.

I feel a bit sorry for marking such a little thing, but there is a space missing after the `=` ;) Nice find of the time parsing panic btw.

nmathewson (Migrated from github.com) reviewed 2021-11-14 12:40:46 -08:00

src/lib.rs

nmathewson (Migrated from github.com) commented

2021-11-14 12:40:45 -08:00

good catch; I've pushed and updated version with the space you asked for :)

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: acw/simple_asn1#29