acw/simple_asn1
1
0
Fork 0
Code Issues 5 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Update rust edition to 2021 #32

Closed
Maximkaaa wants to merge 1 commits from update_edition into master
pull from: update_edition
merge into: acw:master
Conversation 2 Commits 1 Files Changed 1 +1 -1
Maximkaaa commented 2022-06-01 07:18:35 -07:00 (Migrated from github.com)
Copy Link

Using older Cargo resolver introduces an issue with time dependency features. The quickcheck feature of time create, specified in the dev-dependencies block gets used even for non-dev dependencies and in all crates that use simple_asn1. Updating the edition fixes the issue.

Another option is to specify the resolver type 2 in Cargo.tom, but I cannot think of any downsides of using more recent language version.

Please, refer to this issue for reference: https://github.com/rust-lang/cargo/issues/10719

Using older Cargo resolver introduces an issue with `time` dependency features. The `quickcheck` feature of `time` create, specified in the `dev-dependencies` block gets used even for non-dev dependencies and in all crates that use simple_asn1. Updating the edition fixes the issue. Another option is to specify the resolver type 2 in Cargo.tom, but I cannot think of any downsides of using more recent language version. Please, refer to this issue for reference: https://github.com/rust-lang/cargo/issues/10719
Maximkaaa commented 2022-06-01 08:25:46 -07:00 (Migrated from github.com)
Copy Link

It seems, like this was already fixed by #31 , so no need for this PR. Looking forward to update on crates.io.

It seems, like this was already fixed by #31 , so no need for this PR. Looking forward to update on crates.io.
acw commented 2022-06-03 08:28:52 -07:00 (Migrated from github.com)
Copy Link

Yeah, I was wondering if something else would come in to combine with that change. Looks like I lost that game of chicken.

I just pushed 0.6.2 to crates. Sorry for the inconvenience!

Yeah, I was wondering if something else would come in to combine with that change. Looks like I lost that game of chicken. I just pushed 0.6.2 to crates. Sorry for the inconvenience!
👍 1

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
acw
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: acw/simple_asn1#32
Delete Branch "update_edition"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?